flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [tools] Make release script a bit more flexibl...
Date Fri, 26 Jun 2015 09:23:48 GMT
Github user mxm commented on a diff in the pull request:

    --- Diff: tools/create_release_files.sh ---
    @@ -138,7 +146,7 @@ make_binary_release() {
         echo "Files in uberjar: $NUM_FILES_IN_UBERJAR. Uberjar: $UBERJAR"
         if [ "$NUM_FILES_IN_UBERJAR" -ge "65536" ] ; then
           echo "The number of files in the uberjar ($NUM_FILES_IN_UBERJAR) exceeds the maximum
number of possible files for Java 6 (65536)"
    -      exit 1
    +    #  exit 1
    --- End diff --
    Shouldn't we fail here? What's the point of the check after all?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message