flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andralungu <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API
Date Tue, 23 Jun 2015 09:35:56 GMT
Github user andralungu commented on the pull request:

    https://github.com/apache/flink/pull/808#issuecomment-114420568
  
    Thanks @aljoscha for reminding me... This slipped my mind for a sec. 
    
    I agree that the methods should have Scaladoc (this should be straightforward to add starting
from  the existing Javadoc). What would also be nice, IMO would be to update  the docs so
that they would also contain a Scala version of the example code snippets, similar to the
programming guide, for example (http://ci.apache.org/projects/flink/flink-docs-release-0.8/programming_guide.html).
    
    Furthermore, the newly added methods (e.g. `addVertices`) are missing. However, that should
be a separate Jira.
    
    Apart from the formatting issue and the documentation issue, everything looks nice and
clean :) 
    
      


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message