flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1085] Unnecessary failing of GroupReduc...
Date Mon, 22 Jun 2015 08:50:13 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/854#issuecomment-114043020
  
    I think this code actually simply drops oversized records, or am I overlooking something?
    
    Also, outputting oversized records on WARN debug level seems heavy, it is not really something
that should alert the person that runs the program.
    
    Before merging this, we need to
      - Make sure the records are not lost
      - Add a test that validates exactly that (not as an ITCase, but a unit test)
      - Reduce the log level for large records to DEBUG


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message