flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From szape <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...
Date Mon, 22 Jun 2015 08:20:20 GMT
Github user szape commented on a diff in the pull request:

    https://github.com/apache/flink/pull/853#discussion_r32913023
  
    --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util/FiniteStormFileSpout.java
---
    @@ -0,0 +1,100 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.stormcompatibility.util;
    +
    +import backtype.storm.spout.SpoutOutputCollector;
    +import backtype.storm.task.TopologyContext;
    +import backtype.storm.tuple.Values;
    +import org.apache.flink.stormcompatibility.wrappers.FiniteStormSpout;
    +
    +import java.io.BufferedReader;
    +import java.io.FileNotFoundException;
    +import java.io.FileReader;
    +import java.io.IOException;
    +import java.util.Map;
    +
    +/**
    + * Implements a Storm Spout that reads data from a given local file. The spout stops
automatically
    + * when it reached the end of the file.
    + */
    +public class FiniteStormFileSpout extends AbstractStormSpout implements FiniteStormSpout
{
    +	private static final long serialVersionUID = -6996907090003590436L;
    +
    +	private final String path;
    +	private BufferedReader reader;
    +	private String line;
    +	private boolean newLineRead;
    +
    +	public FiniteStormFileSpout(final String path) {
    +		this.path = path;
    +	}
    +
    +	@SuppressWarnings("rawtypes")
    +	@Override
    +	public void open(final Map conf, final TopologyContext context,
    +			final SpoutOutputCollector collector) {
    +		super.open(conf, context, collector);
    +		try {
    +			this.reader = new BufferedReader(new FileReader(this.path));
    +		} catch (final FileNotFoundException e) {
    +			throw new RuntimeException(e);
    +		}
    +		newLineRead = false;
    +	}
    +
    +	@Override
    +	public void close() {
    +		if (this.reader != null) {
    +			try {
    +				this.reader.close();
    +			} catch (final IOException e) {
    +				throw new RuntimeException(e);
    +			}
    +		}
    +	}
    +
    +	@Override
    +	public void nextTuple() {
    +		if (!reachedEnd()) {
    +			this.collector.emit(new Values(line));
    +		}
    +		newLineRead = false;
    +	}
    +
    +	/**
    +	 * Can be called before nextTuple() any times including 0.
    +	 */
    +	public boolean reachedEnd() {
    +		try {
    +			readLine();
    +		} catch (IOException e) {
    +			e.printStackTrace();
    --- End diff --
    
    Thanks for pointing it out! I fixed it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message