flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sahitya-pavurala <...@git.apache.org>
Subject [GitHub] flink pull request: Modified the equals method in all the Value ty...
Date Thu, 18 Jun 2015 11:34:15 GMT
Github user sahitya-pavurala commented on the pull request:

    https://github.com/apache/flink/pull/850#issuecomment-113121714
  
    instanceOf being an operator will return false if its a null reference , but getClass
being a method will give an exception(I think so), also use of getClass makes more sense since
its a equals method and we want both the types to be identical(no sub types) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message