flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbalassi <...@git.apache.org>
Subject [GitHub] flink pull request: [build] Merge transitive notice files to shade...
Date Tue, 16 Jun 2015 13:37:36 GMT
Github user mbalassi commented on the pull request:

    https://github.com/apache/flink/pull/837#issuecomment-112432774
  
    Found the bug, was a trivial one on my side. Now the produced NOTICE looks the following
for e.g. flink-shaded-hadoop. [1] 
    
    It would be a bit nicer if we could clearly state the NOTICE belongs to a Flink jar, but
that is not ensured currently. I have looked at the source code of the transformer we are
using and other Maven projects with shading and I did not find approaches different from the
current one, so I hope that this solution is sufficient.
    
    [1] http://pastebin.com/xB638R28


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message