flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2174] Allow comments in 'slaves' file
Date Mon, 08 Jun 2015 13:23:46 GMT
Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/796#issuecomment-109994289
  
    >mjsax@T420s-dbis-mjsax:~$ SLAVE="#comment"; if [[ "$SLAVE" =~ ^([0-9a-zA-Z/.-]+).$
]] ; then echo "${BASH_REMATCH[1]}"; else echo "missmatch"; fi
    missmatch
    
    Exactly. So, it works as expected. It returns an empty string in case the host is commented
out. With your changes, it will then not be considered as a host name.
    
    >mjsax@T420s-dbis-mjsax:~$ SLAVE="host#comment"; if [[ "$SLAVE" =~ ^([0-9a-zA-Z/.-]+).$
]] ; then echo "${BASH_REMATCH[1]}"; else echo "missmatch"; fi
    host
    
    That's also fine because it should remove the comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message