flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2182] Add stateful Streaming Sequence S...
Date Mon, 08 Jun 2015 13:07:51 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/804#discussion_r31911662
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
    @@ -412,7 +412,7 @@ public void registerType(Class<?> type) {
     		if (from > to) {
     			throw new IllegalArgumentException("Start of sequence must not be greater than the
end");
     		}
    -		return fromCollection(new NumberSequenceIterator(from, to), BasicTypeInfo.LONG_TYPE_INFO,
"Sequence Source");
    +		return addSource(new StatefulSequenceSource(from, to), "Sequence Source").setParallelism(1);
     	}
    --- End diff --
    
    But why wouldn't we allow the user to explicitly set a higher parallelism. The call is
quite explicit and I think I would be more surprised as a user if my source did not run in
parallel even though I set a higher parallelism. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message