Return-Path: 
 <issues-return-15412-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id BE29717C9C
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Mon, 18 May 2015 19:40:02 +0000 (UTC)
Received: (qmail 43582 invoked by uid 500); 18 May 2015 19:40:02 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 43335 invoked by uid 500); 18 May 2015 19:40:02 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 43126 invoked by uid 99); 18 May 2015 19:40:02 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 May 2015 19:40:02 +0000
Date: Mon, 18 May 2015 19:40:02 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12787831.1428012192000.147317.1431978002490@Atlassian.JIRA>
In-Reply-To: <JIRA.12787831.1428012192000@Atlassian.JIRA>
References: <JIRA.12787831.1428012192000@Atlassian.JIRA>
 <JIRA.12787831.1428012192246@arcas>
Subject: [jira] [Commented] (FLINK-1820) Bug in DoubleParser and FloatParser
 - empty String is not casted to 0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/FLINK-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548619#comment-14548619 ] 

ASF GitHub Bot commented on FLINK-1820:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/566#discussion_r30540219
  
    --- Diff: flink-core/src/main/java/org/apache/flink/types/parser/ByteParser.java ---
    @@ -21,22 +21,23 @@
     
     
     public class ByteParser extends FieldParser<Byte> {
    -	
    --- End diff --
    
    Please avoid such reformatting changes in the future.
    In this file less than 10 changed lines make up the actual change but almost 80 lines are touched. This costs quite a bit of time to review.


> Bug in DoubleParser and FloatParser - empty String is not casted to 0
> ---------------------------------------------------------------------
>
>                 Key: FLINK-1820
>                 URL: https://issues.apache.org/jira/browse/FLINK-1820
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.8.0, 0.9, 0.8.1
>            Reporter: Felix Neutatz
>            Assignee: Felix Neutatz
>            Priority: Critical
>             Fix For: 0.9
>
>
> Hi,
> I found the bug, when I wanted to read a csv file, which had a line like:
> "||\n"
> If I treat it as a Tuple2<Long,Long>, I get as expected a tuple (0L,0L).
> But if I want to read it into a Double-Tuple or a Float-Tuple, I get the following error:
> java.lang.AssertionError: Test failed due to a org.apache.flink.api.common.io.ParseException: Line could not be parsed: '||'
> ParserError NUMERIC_VALUE_FORMAT_ERROR 
> This error can be solved by adding an additional condition for empty strings in the FloatParser / DoubleParser.
> We definitely need the CSVReader to be able to read "empty values".
> I can fix it like described if there are no better ideas :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)