Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 78857188FD for ; Sun, 31 May 2015 23:07:39 +0000 (UTC) Received: (qmail 88825 invoked by uid 500); 31 May 2015 23:07:39 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 88778 invoked by uid 500); 31 May 2015 23:07:39 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 88769 invoked by uid 99); 31 May 2015 23:07:39 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 31 May 2015 23:07:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id F02B2C0B58 for ; Sun, 31 May 2015 23:07:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.009 X-Spam-Level: X-Spam-Status: No, score=-0.009 tagged_above=-999 required=6.31 tests=[T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id pTk29hkKcUnC for ; Sun, 31 May 2015 23:07:26 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 0925547BCB for ; Sun, 31 May 2015 23:07:25 +0000 (UTC) Received: (qmail 88695 invoked by uid 99); 31 May 2015 23:07:25 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 31 May 2015 23:07:25 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 43F1FE011B; Sun, 31 May 2015 23:07:25 +0000 (UTC) From: StephanEwen To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request: [FLINK-2076] [runtime] Fix memory leakage in M... Content-Type: text/plain Message-Id: <20150531230725.43F1FE011B@git1-us-west.apache.org> Date: Sun, 31 May 2015 23:07:25 +0000 (UTC) Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/751#issuecomment-107255722 Thanks, this looks like some seriously great debugging! Very nice :-) It would be great if you could add a test that produces the error without the fix, and validates that the fix resolved it. I would guess that you have a setup that produced this error (for debugging). Can you add this as a test? Also, can we change the fix such that it adds a second memory segment, if it is non-null? That would help maintain the performance characteristics of the current code. I vaguely remember that there was a reason to add two memory segments (that code was written quite a while ago and I should have put more comments into the code). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---