Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 16AB118F92 for ; Mon, 18 May 2015 16:43:22 +0000 (UTC) Received: (qmail 44211 invoked by uid 500); 18 May 2015 16:43:22 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 44165 invoked by uid 500); 18 May 2015 16:43:22 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 44156 invoked by uid 99); 18 May 2015 16:43:21 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 May 2015 16:43:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9202E1823FE for ; Mon, 18 May 2015 16:43:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.971 X-Spam-Level: X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id IKNT_mzJ81q6 for ; Mon, 18 May 2015 16:43:15 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 0E72D24BB6 for ; Mon, 18 May 2015 16:43:14 +0000 (UTC) Received: (qmail 44079 invoked by uid 99); 18 May 2015 16:43:14 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 May 2015 16:43:14 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9EC5FE0914; Mon, 18 May 2015 16:43:14 +0000 (UTC) From: mxm To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request: [FLINK-2025] add support for booleans in csv p... Content-Type: text/plain Message-Id: <20150518164314.9EC5FE0914@git1-us-west.apache.org> Date: Mon, 18 May 2015 16:43:14 +0000 (UTC) Github user mxm commented on the pull request: https://github.com/apache/flink/pull/685#issuecomment-103122448 IMHO the current behavior is well-defined. As you said, it's a question of making a choice and sticking to it. I would add a case-insensitive check for `true` but swallowing all other values doesn't seem right to me. However, if that's the common by behavior of parses in the Java world, I'm not going to insist on the current behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---