flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsaputra <...@git.apache.org>
Subject [GitHub] flink pull request: Change FlinkMiniCluster#HOSTNAME to FlinkMiniC...
Date Thu, 21 May 2015 17:34:02 GMT
GitHub user hsaputra opened a pull request:

    https://github.com/apache/flink/pull/711

    Change FlinkMiniCluster#HOSTNAME to FlinkMiniCluster#hostname to match naming convention.

    The FlinkMiniCluster contain member variable called HOSTNAME which all caps. The naming
of al caps usually reserved for constants and static variable.
    
    The PR is changing the name of the variable and the usages.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hsaputra/flink update_hostname_to_match_conventions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/711.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #711
    
----
commit 2a2f3bd9f9e6edab44f3c1de76952bd62b12680d
Author: hsaputra <hsaputra@apache.org>
Date:   2015-05-21T17:31:39Z

    Change FlinkMiniCluster#HOSTNAME to FlinkMiniCluster#hostname to match naming convention.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message