flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1975) Graph getUndirected improvement
Date Tue, 05 May 2015 17:09:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528814#comment-14528814
] 

ASF GitHub Bot commented on FLINK-1975:
---------------------------------------

GitHub user andralungu opened a pull request:

    https://github.com/apache/flink/pull/653

    [FLINK-1975][gelly] Graph getUndirected improvement

    We were using an union of two data sets to create the undirected graph. This could be
done by simply calling a flatMap. 
    
    Thanks for the tip @fhueske! :)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andralungu/flink getUndirected

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/653.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #653
    
----
commit d89addc0fd2e5e64de1667f0d701d901fa57c627
Author: andralungu <lungu.andra@gmail.com>
Date:   2015-05-08T17:01:53Z

    [FLINK-1975][gelly] Graph getUndirected improvement

----


> Graph getUndirected improvement 
> --------------------------------
>
>                 Key: FLINK-1975
>                 URL: https://issues.apache.org/jira/browse/FLINK-1975
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 0.9
>            Reporter: Andra Lungu
>            Assignee: Andra Lungu
>            Priority: Minor
>              Labels: easyfix
>
> The current getUndirected method uses a union and a map to add the reverse edges to the
graph. This could be done by simply using a flatMap that adds the edge and its reversed version
- a flatMap is less expensive than a union followed by a map.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message