flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2076] [runtime] Fix memory leakage in M...
Date Sun, 31 May 2015 23:07:25 GMT
Github user StephanEwen commented on the pull request:

    Thanks, this looks like some seriously great debugging! Very nice :-)
    It would be great if you could add a test that produces the error without the fix, and
validates that the fix resolved it. I would guess that you have a setup that produced this
error (for debugging). Can you add this as a test?
    Also, can we change the fix such that it adds a second memory segment, if it is non-null?
That would help maintain the performance characteristics of the current code. I vaguely remember
that there was a reason to add two memory segments (that code was written quite a while ago
and I should have put more comments into the code).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message