flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1319][core] Add static code analysis fo...
Date Thu, 28 May 2015 08:37:56 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/729#issuecomment-106232545
  
    I second Ufuk's comments.
    Merging it and deactivating it by default. I can see a 0.9.1 or 0.10.0 release coming
in very soon afterwards, because we have a big set of issues still in the pipeline.
    
    Initially activating hinting in the local environment (what people use during debigging
anyways) and having it deactivated in the "production" environments (remote and context).
    
    Other comments:
      - How about printing the hints to sysout? I can see them getting lost among the logging
statements. Also, people often have logging not activated in the IDE.
      - Package based exclusions never worked, it was always an issue with the quickstarts.
I assume you want the exclusion to make sure you do not analyze the built-in default join
function, for example? What you can do is add an annotation that says "DoNotAnalyze" to that
functions, and then simply analyze everything.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message