flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HilmiYildirim <...@git.apache.org>
Subject [GitHub] flink pull request: Implemented TwitterSourceFilter and adapted Tw...
Date Tue, 26 May 2015 06:34:56 GMT
Github user HilmiYildirim commented on the pull request:

    https://github.com/apache/flink/pull/695#issuecomment-105415577
  
    The problem is as follows. While I was working on the commit, the interface SourceFunction
has changed and was merged with the master. Now, it has the methods reachedEnd and next. Cause
TwitterSource inherits from SourceFunction, the nextReachedEnd and next methods were implemented
in the class. The problem os that the implementation has bugs and the old methods are not
deleted which leads to that the class also has dead code. Therefore, the TwitterFilterSource
class was not working and, therefore, TwitterFilterSource was also not working. Therefore,
I have fixed the class TwitterSource and removed the old code. Now, it is working properly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message