flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andralungu <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...
Date Mon, 25 May 2015 17:46:41 GMT
Github user andralungu commented on the pull request:

    Hi @vasia, 
    I updated the addition methods to fit your suggestion. Feedback, for both of us in the
future: discuss implementation details like just add vertices and remove the list of edges
before the code is written. 98% of the people would have kept the edge list for compatibility
with the addVertex method that we already had. 
    Regarding edge/vertex removal, I just changed the arg to List. A difference operator will
not do us any good for various reasons: 
    - that worked for union because the DataSet also had an union operator
    - fromCollection() will never take an empty data set as a parameter so when you do removeVertices,
you cannot use the difference operator. Workaround: generate an empty set by adding and removing
an element. But really? 
    - when doing a "difference" on the vertices, you also need to remove the edges for which
the vertex that disappeared was either source or target, so you will return a graph not a
DataSet of vertices like is the case for union. Therefore a difference that operates on vertex
data sets and returns a graph is exactly my removeVertices(). I guess you wanted to have Graph
difference(graph) - back to argument 2. 
    Could you describe what you meant by a difference similar to union in more detail? 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message