flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1980] allowing users to decorate input ...
Date Mon, 11 May 2015 19:26:21 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/658#issuecomment-101024456
  
    Looks good. One comment, though:
     - The position tracking in the stream wrapper is a nice idea, but since the `skip()`
method is anyways only a hint (it may skip less if it wants) and seeking works only in one
direction, why not skip seek support completely? Also simplifies the code and makes it even
more lightweight.
    
    As a followup: Should we add more built-in decompressors for other file endings, like
`*.gz` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message