flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1977] Rework Stream Operators to always...
Date Thu, 07 May 2015 13:58:07 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/659#discussion_r29853728
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/graph/JSONGenerator.java
---
    @@ -165,11 +165,10 @@ private void decorateNode(Integer vertexID, JSONObject node) throws
JSONExceptio
     			node.put(PACT, "Data Stream");
     		}
     
    -		StreamOperator<?, ?> operator = streamGraph.getStreamNode(vertexID).getOperator();
    +		StreamOperator<?> operator = streamGraph.getStreamNode(vertexID).getOperator();
     
    -		if (operator != null && operator.getUserFunction() != null) {
    -			node.put(CONTENTS, vertex.getOperatorName() + " at "
    -					+ operator.getUserFunction().getClass().getSimpleName());
    +		if (operator != null) {
    +			node.put(CONTENTS, vertex.getOperatorName());
     		} else {
     			node.put(CONTENTS, vertex.getOperatorName());
     		}
    --- End diff --
    
    The if statement is doing the same in both cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message