flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1977] Rework Stream Operators to always...
Date Thu, 07 May 2015 13:23:46 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/659#discussion_r29850553
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/KafkaSource.java
---
    @@ -178,38 +182,45 @@ private void initializeConnection() {
     		consumerIterator = stream.iterator();
     	}
     
    -	/**
    -	 * Called to forward the data from the source to the {@link DataStream}.
    -	 * 
    -	 * @param collector
    -	 *            The Collector for sending data to the dataStream
    -	 */
     	@Override
    -	public void run(Collector<OUT> collector) throws Exception {
    -		isRunning = true;
    -		try {
    -			while (isRunning && consumerIterator.hasNext()) {
    -				OUT out = schema.deserialize(consumerIterator.next().message());
    -				if (schema.isEndOfStream(out)) {
    -					break;
    -				}
    -				collector.collect(out);
    +	public void open(Configuration config) throws Exception {
    +		initializeConnection();
    +	}
    +
    +	@Override
    +	public boolean reachedEnd() throws Exception {
    +		if (nextElement != null) {
    +			return true;
    +		} else if (consumerIterator.hasNext()) {
    +			OUT out = schema.deserialize(consumerIterator.next().message());
    +			if (schema.isEndOfStream(out)) {
    +				return false;
     			}
    -		} finally {
    -			consumer.shutdown();
    +			nextElement = out;
     		}
    +		return false;
     	}
     
     	@Override
    -	public void open(Configuration config) throws Exception {
    -		initializeConnection();
    +	public OUT next() throws Exception {
    +		if (nextElement != null) {
    +			OUT out = nextElement;
    +			nextElement = null;
    +			return out;
    +		}
    +
    +		MessageWithMetadata msg;
    +		OUT out = schema.deserialize(consumerIterator.next().message());
    +
    +		if (schema.isEndOfStream(out)) {
    +			throw new RuntimeException("Kafka stream is at end.");
    +		}
    +
    +		return out;
     	}
     
     	@Override
    -	public void cancel() {
    -		isRunning = false;
    -		if (consumer != null) {
    -			consumer.shutdown();
    --- End diff --
    
    When the operator is done (`close()` method?) we should shutdown the consumer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message