Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0F67B10C27 for ; Mon, 27 Apr 2015 13:17:05 +0000 (UTC) Received: (qmail 83829 invoked by uid 500); 27 Apr 2015 13:17:05 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 83794 invoked by uid 500); 27 Apr 2015 13:17:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 83785 invoked by uid 99); 27 Apr 2015 13:17:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Apr 2015 13:17:04 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: message received from 54.191.145.13 which is an MX secondary for issues@flink.apache.org) Received: from [54.191.145.13] (HELO mx1-us-west.apache.org) (54.191.145.13) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Apr 2015 13:17:00 +0000 Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 83C2A2737B for ; Mon, 27 Apr 2015 13:16:40 +0000 (UTC) Received: (qmail 82412 invoked by uid 99); 27 Apr 2015 13:16:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Apr 2015 13:16:39 +0000 Date: Mon, 27 Apr 2015 13:16:39 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-1820) Bug in DoubleParser and FloatParser - empty String is not casted to 0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FLINK-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514102#comment-14514102 ] ASF GitHub Bot commented on FLINK-1820: --------------------------------------- Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/566#issuecomment-96647676 Looks good. I added few minor comments inline. Did you check if the changes should also go into the `ByteParser`? > Bug in DoubleParser and FloatParser - empty String is not casted to 0 > --------------------------------------------------------------------- > > Key: FLINK-1820 > URL: https://issues.apache.org/jira/browse/FLINK-1820 > Project: Flink > Issue Type: Bug > Components: Core > Affects Versions: 0.8.0, 0.9, 0.8.1 > Reporter: Felix Neutatz > Assignee: Felix Neutatz > Priority: Critical > Fix For: 0.9 > > > Hi, > I found the bug, when I wanted to read a csv file, which had a line like: > "||\n" > If I treat it as a Tuple2, I get as expected a tuple (0L,0L). > But if I want to read it into a Double-Tuple or a Float-Tuple, I get the following error: > java.lang.AssertionError: Test failed due to a org.apache.flink.api.common.io.ParseException: Line could not be parsed: '||' > ParserError NUMERIC_VALUE_FORMAT_ERROR > This error can be solved by adding an additional condition for empty strings in the FloatParser / DoubleParser. > We definitely need the CSVReader to be able to read "empty values". > I can fix it like described if there are no better ideas :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)