Return-Path: 
 <issues-return-13414-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 632AB172A2
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Thu, 23 Apr 2015 13:26:25 +0000 (UTC)
Received: (qmail 97841 invoked by uid 500); 23 Apr 2015 13:26:25 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 97799 invoked by uid 500); 23 Apr 2015 13:26:25 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 97790 invoked by uid 99); 23 Apr 2015 13:26:25 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2015 13:26:25 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=5.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: message received from 54.164.171.186
 which is an MX secondary for issues@flink.apache.org)
Received: from [54.164.171.186] (HELO mx1-us-east.apache.org) (54.164.171.186)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2015 13:26:20 +0000
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with
 SMTP id 497CC43CDC
	for <issues@flink.incubator.apache.org>;
 Thu, 23 Apr 2015 13:26:00 +0000 (UTC)
Received: (qmail 97609 invoked by uid 99); 23 Apr 2015 13:25:59 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2015 13:25:59 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id C0207E1789; Thu, 23 Apr 2015 13:25:59 +0000 (UTC)
From: StephanEwen <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-571-flink@git.apache.org>
In-Reply-To: <git-pr-571-flink@git.apache.org>
Subject: [GitHub] flink pull request: Fixed Configurable HadoopOutputFormat
 (FLINK-1...
Content-Type: text/plain
Message-Id: <20150423132559.C0207E1789@git1-us-west.apache.org>
Date: Thu, 23 Apr 2015 13:25:59 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/571#discussion_r28961417
  
    --- Diff: flink-staging/flink-hbase/pom.xml ---
    @@ -112,6 +112,12 @@ under the License.
     				</exclusion>
     			</exclusions>
     		</dependency>
    +		<dependency>
    --- End diff --
    
    Fair enough. Then the dependency should not be in test scope, but in the default scope, so users get this dependency into their fat jar as well when using the HBase output format. May be worth to define a few exclusions, though, to not get the complete tail of transitive HBase dependencies (I think that even includes JRuby and so on)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---