Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Received-SPF: pass (athena.apache.org: message received from 54.191.145.13
 which is an MX secondary for issues@flink.apache.org)
From: vasia <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-408-flink@git.apache.org>
In-Reply-To: <git-pr-408-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-1514][Gelly] Add a
 Gather-Sum-Apply ite...
Content-Type: text/plain
Message-Id: <20150418170249.60069E022F@git1-us-west.apache.org>
Date: Sat, 18 Apr 2015 17:02:49 +0000 (UTC)

Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/408#discussion_r28645615
  
    --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/RichEdge.java ---
    @@ -0,0 +1,47 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.graph.gsa;
    +
    +import org.apache.flink.api.java.tuple.Tuple2;
    +
    +import java.io.Serializable;
    +
    +/**
    + * This class represents a <sourceVertex, edge> pair
    + * This is a wrapper around Tuple2<VV, EV> for convenience in the GatherFunction
    + * @param <VV> the vertex value type
    + * @param <EV> the edge value type
    + */
    +public class RichEdge<VV extends Serializable, EV extends Serializable>
    --- End diff --
    
    I don't really like the name `RichEdge`, but I don't have a better suggestion.. It's essentially a pair of the neighboring edge and vertex value, right? Should we simply call it `Neighbor` or `NeighborData` or `NeighborValue`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---