flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andralungu <...@git.apache.org>
Subject [GitHub] flink pull request: [gelly][Refactoring] Removed example string
Date Sun, 26 Apr 2015 18:20:22 GMT
GitHub user andralungu opened a pull request:

    https://github.com/apache/flink/pull/625

    [gelly][Refactoring] Removed example string

    @vasia,
    
    Just FYI :), in example/utils we have a class EdgeWithLongIdNullValueParser that is never
used.
     
    The examples that correspond to the library methods, e.g. PageRankExample cannot be renamed
because that will cause a collision with the method name, in this case, PageRank. I guess
that's why we added "Example" to the class name in the first place. 
    
    To me the examples look good as they are in this commit. If you have another idea for
the library method examples, let me know, but in my view Example is better than Usage, or
whatever different word we may come up with. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andralungu/flink examples

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/625.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #625
    
----
commit d6414eae54a2bafdba4457ffb2aa0bd1d34ad57d
Author: andralungu <lungu.andra@gmail.com>
Date:   2015-04-26T18:09:04Z

    [gelly][Refactoring] Removed example string

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message