flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1847) Change Scala collect() method to return a Seq
Date Thu, 09 Apr 2015 12:11:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487267#comment-14487267
] 

ASF GitHub Bot commented on FLINK-1847:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/583

    [FLINK-1847] Changes collect to return a Seq[T] and adds parentheses

    Changes the return type of Scala API's collect method to Seq[T] and adds parentheses to
collect and count methods.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixScalaCollect

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/583.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #583
    
----
commit cf1b2e3da4e9a9ded929a73d2ecce2fb4046b778
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2015-04-09T10:26:53Z

    [FLINK-1847] [Scala API] Changes the return type of Scala API's collect method to Seq[T]
and adds parentheses to collect and count methods.
    
    [FLINK-1847] [Scala API] Updates existing test cases using Scala API's collect/count method.

----


> Change Scala collect() method to return a Seq
> ---------------------------------------------
>
>                 Key: FLINK-1847
>                 URL: https://issues.apache.org/jira/browse/FLINK-1847
>             Project: Flink
>          Issue Type: Bug
>          Components: Scala API
>    Affects Versions: 0.9
>            Reporter: Stephan Ewen
>            Assignee: Till Rohrmann
>
> Right now, the method is very specific in returning {{mutable.Buffer}}. Changing it to
{{Seq}} allows us to alter the underlying representation without breaking the API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message