flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1826) Remove the code never be executed in function getNumPages
Date Sun, 05 Apr 2015 02:35:33 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396033#comment-14396033
] 

ASF GitHub Bot commented on FLINK-1826:
---------------------------------------

Github user matadorhong commented on the pull request:

    https://github.com/apache/flink/pull/569#issuecomment-89706960
  
    OK. I accept it. I will close the PR. Thanks for your answer.


> Remove the code never be executed in function getNumPages
> ---------------------------------------------------------
>
>                 Key: FLINK-1826
>                 URL: https://issues.apache.org/jira/browse/FLINK-1826
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>    Affects Versions: master
>            Reporter: Sibao Hong
>            Assignee: Sibao Hong
>            Priority: Minor
>             Fix For: master
>
>
> Remove the code never be executed in function getNumPages, because the input of numBytes
has be validataion by its caller of DefaultMemoryManager(long memorySize, int numberOfSlots,
int pageSize).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message