flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1741) Add Jaccard Similarity Metric Example
Date Mon, 06 Apr 2015 19:09:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481646#comment-14481646

ASF GitHub Bot commented on FLINK-1741:

Github user vasia commented on the pull request:

    Hey @andralungu. I agree that the code in `GatherNeighbors` might be confusing. In my
opinion, we could do the following to simplify it a bit:
    - get rid of the Iterator and just iterate on the Iterable using a `for (Tuple2... vertexWithEdge
: neighbors) {}` construct.
    - replace the if block that compares the vertex IDs to find the neighbor with a method
`getNeighborID()`, which will extract the correct ID from the Edge. I think this will make
the logic of the example clearer.
    What do you think?

> Add Jaccard Similarity Metric Example
> -------------------------------------
>                 Key: FLINK-1741
>                 URL: https://issues.apache.org/jira/browse/FLINK-1741
>             Project: Flink
>          Issue Type: Task
>          Components: Gelly
>    Affects Versions: 0.9
>            Reporter: Andra Lungu
>            Assignee: Andra Lungu
> http://www.inside-r.org/packages/cran/igraph/docs/similarity

This message was sent by Atlassian JIRA

View raw message