flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-924) Extend JarFileCreator to automatically include dependencies
Date Tue, 28 Apr 2015 09:03:06 GMT

    [ https://issues.apache.org/jira/browse/FLINK-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516690#comment-14516690
] 

ASF GitHub Bot commented on FLINK-924:
--------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/35#issuecomment-96982580
  
    Very good!
    
    Is there a way we can integrate this deeper with the remote environment? Something like
`env.autoCollectDependencies()` and then it internally build the jar by itself?


> Extend JarFileCreator to automatically include dependencies
> -----------------------------------------------------------
>
>                 Key: FLINK-924
>                 URL: https://issues.apache.org/jira/browse/FLINK-924
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ufuk Celebi
>            Assignee: Mingliang Qi
>            Priority: Minor
>
> We have a simple {{JarFileCreator}}, which allows to add classes to a JAR file as follows:
> {code:java}
> JarFileCreator jfc = new JarFileCreator(jarFile);
> jfc.addClass(X.class);
> jfc.addClass(Y.class);
> jfc.createJarFile();
> {code}
> The created file can then be used with the remote execution environment, which requires
a JAR file to ship.
> I propose the following improvement: use [ASM|http://asm.ow2.org/] to extract all dependencies
and add create the JAR file automatically.
> There is an [old tutorial|http://asm.ow2.org/doc/tutorial-asm-2.0.html] (for ASM 2),
which implements a {{DependencyVisitor}}. Unfortuneately the code does not directly work with
ASM 5, but it should be a good starting point.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message