flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-703) Use complete element as join key.
Date Mon, 06 Apr 2015 11:33:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481150#comment-14481150

ASF GitHub Bot commented on FLINK-703:

Github user chiwanpark commented on the pull request:

    @hsaputra Thanks for advice! I renamed `BasicKeySelector` to `IdentityKeySelector` to
prevent ambiguous naming. I added JavaDoc for `IdentityKeySelector`.
    BTW, I found some duplicated classes with `IdentityKeySelector` ([1](https://github.com/apache/flink/blob/master/flink-optimizer/src/test/java/org/apache/flink/optimizer/testfunctions/IdentityKeyExtractor.java),
Should I substitute the `IdentityKeySelector` for them? It will decrease the amount of duplicated

> Use complete element as join key.
> ---------------------------------
>                 Key: FLINK-703
>                 URL: https://issues.apache.org/jira/browse/FLINK-703
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: GitHub Import
>            Assignee: Chiwan Park
>            Priority: Trivial
>              Labels: github-import
>             Fix For: pre-apache
> In some situations such as semi-joins it could make sense to use a complete element as
join key. 
> Currently this can be done using a key-selector function, but we could offer a shortcut
for that.
> This is not an urgent issue, but might be helpful.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/703
> Created by: [fhueske|https://github.com/fhueske]
> Labels: enhancement, java api, user satisfaction, 
> Milestone: Release 0.6 (unplanned)
> Created at: Thu Apr 17 23:40:00 CEST 2014
> State: open

This message was sent by Atlassian JIRA

View raw message