flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbalassi <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1948] [streaming] Manual task slot shar...
Date Wed, 29 Apr 2015 11:59:13 GMT
Github user mbalassi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/634#discussion_r29328859
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/SingleOutputStreamOperator.java
---
    @@ -118,11 +118,43 @@ protected SingleOutputStreamOperator(DataStream<OUT> dataStream)
{
     		return new SingleOutputStreamOperator<OUT, O>(this);
     	}
     
    -	public SingleOutputStreamOperator<OUT, O> setChainingStrategy(ChainingStrategy
strategy) {
    +	/**
    +	 * Sets the {@link ChainingStrategy} for the given operator affecting the
    +	 * way operators will possibly be co-located on the same thread for
    +	 * increased performance.
    +	 * 
    +	 * @param strategy
    +	 *            The selected {@link ChainingStrategy}
    +	 * @return The operator with the modified chaining strategy
    +	 */
    +	private SingleOutputStreamOperator<OUT, O> setChainingStrategy(ChainingStrategy
strategy) {
     		this.operator.setChainingStrategy(strategy);
     		return this;
     	}
    -	
    +
    +	/**
    +	 * Turns of chaining for this operator so thread co-location will not be
    +	 * used as an optimization. </p> Chaining can be turned off for the whole
    --- End diff --
    
    Typo: Turns off :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message