flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1933] Add distance measure interface an...
Date Wed, 29 Apr 2015 09:28:05 GMT
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/629#issuecomment-97368054
  
    Hi @chiwanpark. Really good work :-) I had only some minor comments.
    
    One think to think about is where we place the distance measures. Currently it is in the
`flink.ml.common.distance` package. Maybe we could put them in a `metrics.distances` package
instead. We could either put it directly under `flink.ml` or under `flink.ml.math`. What do
you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message