flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-1950: Change heap safety margin computat...
Date Tue, 28 Apr 2015 14:17:07 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/637#discussion_r29246446
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -197,10 +197,19 @@
     	 * Upper bound for heap cutoff on YARN.
     	 * The "yarn.heap-cutoff-ratio" is removing a certain ratio from the heap.
     	 * This value is limiting this cutoff to a absolute value.
    +	 *
    +	 * THE VALUE IS NO LONGER IN USE.
     	 */
    +	@Deprecated
     	public static final String YARN_HEAP_LIMIT_CAP = "yarn.heap-limit-cap";
     
     	/**
    +	 * Minimum amount of memory to remove from the heap space as a safety margin.
    +	 */
    +	public static final String YARN_MIN_HEAP_CUTOFF = "yarn.heap-cutoff-min";
    --- End diff --
    
    Why call it ```yarn.heap-cutoff-min``` and the variable ```YARN_MIN_HEAP_CUTOFF```. Maybe
we can make it consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message