flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vasia <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...
Date Sat, 18 Apr 2015 13:18:35 GMT
Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/537#discussion_r28643940
  
    --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexCentricIteration.java
---
    @@ -228,48 +213,92 @@ public void setInput(DataSet<Vertex<VertexKey, VertexValue>>
inputData) {
     	{
     		return new VertexCentricIteration<VertexKey, VertexValue, Message, EdgeValue>(uf,
mf, edgesWithValue, maximumNumberOfIterations);
     	}
    -	
    +
    +	/**
    +	 * Configures this vertex-centric iteration with the provided parameters.
    +	 *
    +	 * @param parameters the configuration parameters
    +	 */
    +	public void configure(IterationConfiguration parameters) {
    +		this.configuration = parameters;
    +	}
    +
    +	/**
    +	 * @return the configuration parameters of this vertex-centric iteration
    +	 */
    +	public IterationConfiguration getIterationConfiguration() {
    +		return this.configuration;
    +	}
    +
     	// --------------------------------------------------------------------------------------------
     	//  Wrapping UDFs
     	// --------------------------------------------------------------------------------------------
     	
    -	private static final class VertexUpdateUdf<VertexKey extends Comparable<VertexKey>
& Serializable, 
    -		VertexValue extends Serializable, Message> 
    -		extends RichCoGroupFunction<Tuple2<VertexKey, Message>, Vertex<VertexKey,
VertexValue>, Vertex<VertexKey, VertexValue>>
    -		implements ResultTypeQueryable<Vertex<VertexKey, VertexValue>>
    +	private static abstract class VertexUpdateUdf<VertexKey extends Comparable<VertexKey>
& Serializable,
    +		VV extends Serializable, VertexValue extends Serializable, Message>
    --- End diff --
    
    If we change VertexValue type to VV, we should be consistent and change it throughout
the class. We could also simplify VertexKey to K and EdgeValue to EV to be consistent with
the rest of the classes in Gelly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message