flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vasia <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...
Date Sat, 18 Apr 2015 11:56:44 GMT
Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/537#discussion_r28643520
  
    --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/IterationConfiguration.java
---
    @@ -189,4 +199,33 @@ public void addBroadcastSetForUpdateFunction(String name, DataSet<?>
data) {
     	public List<Tuple2<String, DataSet<?>>> getMessagingBcastVars() {
     		return this.bcVarsMessaging;
     	}
    +
    +	// ----------------------------------------------------------------------------------
    +	// The direction, degrees and the total number of vertices should be optional.
    +	// The user can access them by setting the direction, degrees or the numVertices options.
    +	// ----------------------------------------------------------------------------------
    --- End diff --
    
    all parameters in this class are optional :-)
    Can you add javadocs to the new methods, like in the methods above?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message