flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matadorhong <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1891]Add the input storageDirectory emp...
Date Fri, 17 Apr 2015 13:48:25 GMT
Github user matadorhong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/601#discussion_r28594789
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
    @@ -64,15 +64,19 @@
     	 * @return the storage directory used by a BLOB service
     	 */
     	static File initStorageDirectory(String storageDirectory) {
    -		File baseDir = storageDirectory != null ?
    -				new File(storageDirectory) :
    -				new File(System.getProperty("java.io.tmpdir"));
    +		File baseDir;
    +		if (storageDirectory == null || storageDirectory.isEmpty()) {
    --- End diff --
    
    Yeah, you are right. Thank for you notes.I have change it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message