flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: Ml branch
Date Fri, 17 Apr 2015 09:24:33 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/579#discussion_r28580607
  
    --- Diff: flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/StandardScalerITSuite.scala
---
    @@ -0,0 +1,154 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.ml.preprocessing
    +
    +import org.apache.flink.api.scala._
    +import org.apache.flink.ml.math.{Vector, DenseVector}
    +import org.apache.flink.test.util.FlinkTestBase
    +import org.scalatest._
    +
    +class StandardScalerITSuite
    +  extends FlatSpec
    +  with Matchers
    +  with FlinkTestBase {
    +
    +  behavior of "Flink's Standard Scaler"
    +
    +  import StandardScalerData._
    +
    +  it should "first center and then properly scale the given vectors" in {
    +
    +    val env = ExecutionEnvironment.getExecutionEnvironment
    +
    +    val dataSet = env.fromCollection(data)
    +    val transformer = new StandardScaler()
    +    val scaledVectors = transformer.transform(dataSet).collect
    --- End diff --
    
    Calculating the mean and std manually and checking against (0, 1) could be helpful as
well. The thing is that nobody knows how the vectors look like after the transformation and
thus can only rely on the correctness of the expected vectors. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message