flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-703] Use complete element as join key
Date Fri, 10 Apr 2015 09:51:08 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/572#discussion_r28133242
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java ---
    @@ -710,6 +711,9 @@ public long count() throws Exception {
     	 * @see DataSet
     	 */
     	public UnsortedGrouping<T> groupBy(String... fields) {
    +		if (Keys.checkForAtomicType(getType(), fields)) {
    --- End diff --
    
    We need to check a few things here.
    - If atomic type, we only allow 
      1. a single expression (`fields.length`)
      1. the expression must be a wildcard expression `"*"`
      1. the atomic type must be a key type (`TypeInformation.isKeyType() == true`)
    - else do as before


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message