flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1589] Add option to pass configuration ...
Date Wed, 01 Apr 2015 13:10:06 GMT
Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/427#issuecomment-88473959
  
    Looks good.
    
    - Can you add missing `@Override` tags to `executePlan` and `getOptimizerPlanAsJSON` while
editing the file?
    - If you only want to ensure that the respective Configuration values are set, we could
indeed just get the configuration object and check that the respective values keys are set
as expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message