Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37FDD178D9 for ; Thu, 5 Mar 2015 02:45:00 +0000 (UTC) Received: (qmail 74042 invoked by uid 500); 5 Mar 2015 02:45:00 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 73998 invoked by uid 500); 5 Mar 2015 02:45:00 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 73989 invoked by uid 99); 5 Mar 2015 02:44:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Mar 2015 02:44:59 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 05 Mar 2015 02:44:58 +0000 Received: (qmail 73715 invoked by uid 99); 5 Mar 2015 02:44:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Mar 2015 02:44:38 +0000 Date: Thu, 5 Mar 2015 02:44:38 +0000 (UTC) From: "Henry Saputra (JIRA)" To: issues@flink.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-1654) Wrong scala example of POJO type in documentation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FLINK-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348029#comment-14348029 ] Henry Saputra commented on FLINK-1654: -------------------------------------- scala> case class Foo(val bar: Int) defined class Foo scala> val test = Foo(2) test: Foo = Foo(2) scala> test.bar res0: Int = 2 scala> > Wrong scala example of POJO type in documentation > ------------------------------------------------- > > Key: FLINK-1654 > URL: https://issues.apache.org/jira/browse/FLINK-1654 > Project: Flink > Issue Type: Bug > Components: Documentation > Affects Versions: 0.9 > Reporter: Chiwan Park > Priority: Trivial > > In [documentation|https://github.com/chiwanpark/flink/blob/master/docs/programming_guide.md#pojos], there is a scala example of POJO > {code} > class WordWithCount(val word: String, val count: Int) { > def this() { > this(null, -1) > } > } > {code} > I think that this is wrong because Flink POJO required public fields or private fields with getter and setter. Fields in scala class is private in default. We should change the field declarations to use `var` keyword or class declaration to case class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)