Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Thu, 12 Mar 2015 11:09:39 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.incubator.apache.org
Message-ID: <JIRA.12778875.1425333118000.74027.1426158579173@Atlassian.JIRA>
In-Reply-To: <JIRA.12778875.1425333118000@Atlassian.JIRA>
References: <JIRA.12778875.1425333118000@Atlassian.JIRA>
 <JIRA.12778875.1425333118345@arcas>
Subject: [jira] [Commented] (FLINK-1633) Add getTriplets() Gelly method
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FLINK-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358497#comment-14358497 ] 

ASF GitHub Bot commented on FLINK-1633:
---------------------------------------

Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/452#discussion_r26293166
  
    --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/utils/Triplet.java ---
    @@ -0,0 +1,55 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.graph.utils;
    +
    +import org.apache.flink.api.java.tuple.Tuple5;
    +import org.apache.flink.graph.Edge;
    +import org.apache.flink.graph.Vertex;
    +
    +import java.io.Serializable;
    +
    +/**
    + * A wrapper around Tuple5 used to avoid duplicate vertex ids and to improve readability in
    --- End diff --
    
    I would prefer a description about what a Triplet is conceptually and how it can be used by user here, instead of explaining that it wraps a Tuple5 :)) 


> Add getTriplets() Gelly method
> ------------------------------
>
>                 Key: FLINK-1633
>                 URL: https://issues.apache.org/jira/browse/FLINK-1633
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>    Affects Versions: 0.9
>            Reporter: Vasia Kalavri
>            Assignee: Andra Lungu
>            Priority: Minor
>              Labels: starter
>
> In some graph algorithms, it is required to access the graph edges together with the vertex values of the source and target vertices. For example, several graph weighting schemes compute some kind of similarity weights for edges, based on the attributes of the source and target vertices. This issue proposes adding a convenience Gelly method that generates a DataSet of <srcVertex, Edge, TrgVertex> triplets from the input graph.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)