Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 186D017293 for ; Fri, 13 Mar 2015 16:23:00 +0000 (UTC) Received: (qmail 62211 invoked by uid 500); 13 Mar 2015 16:23:00 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 62171 invoked by uid 500); 13 Mar 2015 16:23:00 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 62162 invoked by uid 99); 13 Mar 2015 16:22:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Mar 2015 16:22:59 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 13 Mar 2015 16:22:58 +0000 Received: (qmail 61731 invoked by uid 99); 13 Mar 2015 16:22:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Mar 2015 16:22:38 +0000 Date: Fri, 13 Mar 2015 16:22:38 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-1622) Add GroupReducePartial Operator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FLINK-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360573#comment-14360573 ] ASF GitHub Bot commented on FLINK-1622: --------------------------------------- Github user mxm commented on the pull request: https://github.com/apache/flink/pull/466#issuecomment-79096322 @aljoscha @fhueske @hsaputra Thanks for the feedback. Some people suggested that the name is confusing and that my pull request involved too much code duplication. I propose to call the new operator `combineGroup` because it is a combiner that works on Groups, just like the existing combiners in `GroupReduceCombineDriver` and `AllGroupReduceDriver`. I refactored the code to reuse Flink's existing logic for combiners. @hsaputra I added documentation for the operator in the code and the official documentation. Some Scala tests for the API were added as well. When merging this pull request, I would squash the two commits and keep the commit message of the latest one. I simply wanted to keep the first one to show the development process. > Add GroupReducePartial Operator > ------------------------------- > > Key: FLINK-1622 > URL: https://issues.apache.org/jira/browse/FLINK-1622 > Project: Flink > Issue Type: Sub-task > Affects Versions: 0.9 > Reporter: Aljoscha Krettek > > This does what a Reduce or GroupReduce Operator does, except it is only performed on a local partition. > This is also similar to an explicit combine that can output a type that is different from the input. -- This message was sent by Atlassian JIRA (v6.3.4#6332)