Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: hsaputra <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-542-flink@git.apache.org>
In-Reply-To: <git-pr-542-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-1771] Add support for submitting
 single...
Content-Type: text/plain
Message-Id: <20150331041734.D4CECE00BF@git1-us-west.apache.org>
Date: Tue, 31 Mar 2015 04:17:34 +0000 (UTC)

Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/flink/pull/542#discussion_r27452062
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
    @@ -569,15 +590,33 @@ protected int executeProgram(PackagedProgram program, Client client, int paralle
     			program.deleteExtractedLibraries();
     		}
     
    -		LOG.info("Program execution finished");
    +		if(wait) {
    +			LOG.info("Program execution finished");
    +		}
     
    -		// we come here after the job has finished
    +		// we come here after the job has finished (or the job has been submitted)
     		if (execResult != null) {
    -			System.out.println("Job Runtime: " + execResult.getNetRuntime());
    -			Map<String, Object> accumulatorsResult = execResult.getAllAccumulatorResults();
    -			if (accumulatorsResult.size() > 0) {
    -				System.out.println("Accumulator Results: ");
    -				System.out.println(AccumulatorHelper.getResultsFormated(accumulatorsResult));
    +			// if the job has been submitted to a detached YARN cluster, there won't be any
    +			// exec results, but the object will be set (for the job id)
    +			if(yarnCluster != null && yarnCluster.isDetached()) {
    --- End diff --
    
    Small style nit, space after if-else and parentheses.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---