Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0A8CD17F78 for ; Fri, 20 Mar 2015 16:21:18 +0000 (UTC) Received: (qmail 14492 invoked by uid 500); 20 Mar 2015 16:21:11 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 14456 invoked by uid 500); 20 Mar 2015 16:21:11 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 14447 invoked by uid 99); 20 Mar 2015 16:21:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Mar 2015 16:21:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 20 Mar 2015 16:21:10 +0000 Received: (qmail 12677 invoked by uid 99); 20 Mar 2015 16:20:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Mar 2015 16:20:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 56008E10C9; Fri, 20 Mar 2015 16:20:50 +0000 (UTC) From: StephanEwen To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request: [FLINK-1679] rename degree of parallelism to p... Content-Type: text/plain Message-Id: <20150320162050.56008E10C9@git1-us-west.apache.org> Date: Fri, 20 Mar 2015 16:20:50 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/488#issuecomment-84059897 I think all changes that are in `flink-core`, `flink-java`, `flink-scala`, `flink-streaming`, `flink-spargel` are critical. For all those changes, there should be an additional method and the current one should be deprecated. Other changes (Runtime, Optimizer, tests) can be made without any problem. *NOTE:* You are also breaking the system configuration. We should change it to use the new parameter, but we should still accept the config values of the old parameter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---