flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsaputra <...@git.apache.org>
Subject [GitHub] flink pull request: Fix checking null for ternary operator check o...
Date Sat, 07 Mar 2015 01:55:06 GMT
GitHub user hsaputra opened a pull request:

    https://github.com/apache/flink/pull/461

    Fix checking null for ternary operator check on Exception#getMessage calls

    Add parentheses on Exception#getMessage calls from pattern of:
     
    "Initializing the input processing failed" + e.getMessage() == null ? "." : ": " + e.getMessage()
    
    to:
    
    "Initializing the input processing failed" + (e.getMessage() == null ? "." : ": " + e.getMessage())
    
    Extra parentheses needed to make sure ternary operator check on e.getMessage scope call.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hsaputra/flink fix_parentheses_exception_getmessage

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/461.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #461
    
----
commit 1345cbf38cdbf849bdc7c0ff7e29d02fa00bc8fa
Author: Henry Saputra <henry.saputra@gmail.com>
Date:   2015-03-07T01:50:57Z

    Fix checking null for Exception#getMessage call from pattern of:
    
    "Initializing the input processing failed" + e.getMessage() == null ? "." : ": " + e.getMessage()
    
    to:
    
    "Initializing the input processing failed" + (e.getMessage() == null ? "." : ": " + e.getMessage())
    
    Extra parentheses needed to make sure ternary operator check on e.getMessage scope call.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message