flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1679) Document how "degree of parallelism" / "parallelism" / "slots" are connected to each other
Date Thu, 19 Mar 2015 09:15:38 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368743#comment-14368743
] 

ASF GitHub Bot commented on FLINK-1679:
---------------------------------------

Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/488#issuecomment-83433378
  
    Let me explain how I made out the relevant API facing methods to deprecate. Since I changed
all calls to set the parallelism to `getParallelism` or `setParallelism` I did not have to
change classes which already used these methods. To find the remaining which used `setDegreeOfParalleism`
or `getDegreeOfParalleism` method, I did a regexp search in the Java and Scala classes: 
    
    Java: `public .* (get|set)DegreeOfParallelism`
    
    `ExecutionConfig`
    `Operator`
    `CollectionEnvironment`
    `ExecutionEnvironment`
    `StreamExecutionEnvironment`
    `SpargelIteration`
    
    Scala: `def (get|set)DegreeOfParallelism`
    
    `ExecutionEnvironment`
    `StreamExecutionEnvironment`
    
    In these classes I deprecated the methods, and made them call the new methods `getParallelism`
and `setParallelism`. That's how I verified this pull request is not API breaking. For you
inspection, I've created a separate commit with these changes. The deprecated methods are
also covered in the documentation about how to change the parallelism: http://ci.apache.org/projects/flink/flink-docs-master/programming_guide.html#parallel-execution



> Document how "degree of parallelism" /  "parallelism" / "slots" are connected to each
other
> -------------------------------------------------------------------------------------------
>
>                 Key: FLINK-1679
>                 URL: https://issues.apache.org/jira/browse/FLINK-1679
>             Project: Flink
>          Issue Type: Task
>          Components: Documentation
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>            Assignee: Maximilian Michels
>             Fix For: 0.9
>
>
> I see too many users being confused about properly setting up Flink with respect to parallelism.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message