flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-441) Renaming in pact-compiler
Date Tue, 17 Mar 2015 18:58:38 GMT

    [ https://issues.apache.org/jira/browse/FLINK-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365791#comment-14365791

ASF GitHub Bot commented on FLINK-441:

GitHub user StephanEwen opened a pull request:


    [FLINK-441] Rename Pact* and Nephele* classes in the optimizer

    Renames the package `org.apache.flink.compiler` to `org.apache.fink.optimizer`
    Renames `PactCompiler` to `Optimizer`
    Renames `NepheleJobGraphGenerator` to `JobGraphGenerator`
    Renames `PactConnection` to `DagConnection` (since the enclosing data structure is the
Optimizer DAG).
    Renames instances of internal variables and methods that referred to `PactContract` to
refer to `Operator` instead.
    Removes the unnecessary context checker. Was only ever valuable in the deprecated record
    Makes the various graph traversals (previously inner classes of the Optimizer) standalone
classes, which makes the Optimizer class more graspable.
    Migrates some changes from the deprecated Record API to the Java API.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink optimizer_rename

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #492
commit c3868feb6e9618aeb8bdcd500f5f0380abc587f8
Author: Stephan Ewen <sewen@apache.org>
Date:   2015-03-17T09:53:35Z

    [FLINK-441] [optimizer] Rename "o.a.flink.compiler" to "o.a.flink.optimizer"

commit 86f15955a025da5dbf52b243c7340b2d94341c36
Author: Stephan Ewen <sewen@apache.org>
Date:   2015-03-17T09:57:08Z

    [FLINK-441] [optimizer] Removed obsolete plan validator

commit 5c44709642d1442d7bf9a59746a217f37167fec6
Author: Stephan Ewen <sewen@apache.org>
Date:   2015-03-17T10:02:33Z

    [FLINK-441] [optimizer] Remove obsolete and unused utility classes

commit 40ef1b93aa5261b05bfee7d9ff8cf67554f80122
Author: Stephan Ewen <sewen@apache.org>
Date:   2015-03-17T10:24:35Z

    [FLINK-441] [optimizer] Rename Pact* and Nephele* classes
    Also clean up and improve various comments and method names.

commit 211f2742d40240f3820c43aef80108849b4808ff
Author: Stephan Ewen <sewen@apache.org>
Date:   2015-03-17T15:14:50Z

    [optimizer] Migrate first set of tests (branching plans) to new API

commit 3f67a33d84d011942ea4e21f266914a3e53dda72
Author: Stephan Ewen <sewen@apache.org>
Date:   2015-03-17T15:43:28Z

    [optimizer] Moved optimizer graph traversals to dedicated classes to simplify Optimizer


> Renaming in pact-compiler
> -------------------------
>                 Key: FLINK-441
>                 URL: https://issues.apache.org/jira/browse/FLINK-441
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: GitHub Import
>            Priority: Minor
>              Labels: github-import
>             Fix For: pre-apache
> I would like to do a cleanup and renaming in the pact-compiler. Most of the work is in
line with the recent global renaming, but I also want to clear and organize the various representation
structures for the optimized plan. 
> I open this issue to keep track and discuss the suggested renaming.
> We'll have to coordinate the merging of this issue because some renamings (e.g. PactCompiler
-> Compiler) seem to affect a lot of other packages.
> ### Global Scope (Wide Dependencies)
> The following names are part of the public API of stratosphere-compiler. Their renaming
will probably affect a lot of other modules.
> In ```eu.stratosphere.compiler```:
> * ```PactCompiler``` ⇒ ```Compiler```
> ### Module Scope (Narrow Dependencies)
> The following names are part of the internal API of stratosphere-compiler. Their renaming
will probably affect only stratosphere-compiler and stratosphere-tests.
> In ```eu.stratosphere.compiler```:
> * ```DataStatistics``` ⇒ ```StatsStore``` This should be developed as an API for data
stats over *expressions* instead of just over *data sources*.
> * ```NonCachingDataStatistics``` ⇒ *delete*. This class does not seem to be used.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/441
> Created by: [aalexandrov|https://github.com/aalexandrov]
> Labels: 
> Created at: Mon Jan 27 12:33:50 CET 2014
> State: open

This message was sent by Atlassian JIRA

View raw message