flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsaputra <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1688] Socket client sink added
Date Fri, 20 Mar 2015 17:47:37 GMT
Github user hsaputra commented on the pull request:

    https://github.com/apache/flink/pull/484#issuecomment-84086653
  
    @mbalassi, @miguel0afd seemed like the PR contains more commits than the one targeted
for the patch.
    
    Be careful when merging it bc it could murky the history.
    
    I would suggest create clean branch and do rebase instead of merge to keep history clean.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message