flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: Fix issue where Windows paths were not recogni...
Date Tue, 17 Mar 2015 20:40:13 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/491#discussion_r26613687
  
    --- Diff: flink-core/src/test/java/org/apache/flink/core/fs/PathTest.java ---
    @@ -63,6 +63,15 @@ public void testPathFromString() {
     		assertEquals("/my/path", p.toUri().getPath());
     		assertEquals("file", p.toUri().getScheme());
     
    +		p = new Path("C:/my/windows/path");
    +		assertEquals("/C:/my/windows/path", p.toUri().getPath());
    +
    +		p = new Path("file:/C:/my/windows/path");
    +		assertEquals("/C:/my/windows/path", p.toUri().getPath());
    +
    +		p = new Path("C:");
    +		assertEquals("/C:", p.toUri().getPath());
    --- End diff --
    
    Is this a correct path in the end?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message