flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: Add support for building Flink with Scala 2.11
Date Wed, 11 Mar 2015 08:47:25 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/477#discussion_r26195746
  
    --- Diff: flink-scala/pom.xml ---
    @@ -236,4 +230,23 @@ under the License.
     		</plugins>
     	</build>
     
    +	<profiles>
    +		<profile>
    +			<id>scala-2.10</id>
    +			<activation>
    +				<property>
    +					<!-- this is the default scala profile -->
    +					<name>!scala-2.11.profile</name>
    --- End diff --
    
    Ah .. I need to drink more club mate before reviewing pull requests ;)
    The profile is activated by default.
    Then, you can also do
    ```xml
     <activation>
          <activeByDefault>true</activeByDefault>
        </activation>
    ```
    and deactivate it with `-P!scala-2.10`.
    
    Why didn't you make 2.10 the default and add a profile for 2.11 (which seems to be the
special case)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message