flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1605] Bundle all hadoop dependencies an...
Date Tue, 10 Mar 2015 12:56:09 GMT
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/454#issuecomment-78047279
  
    Thank you for reviewing the change.
    
    * The exclusions for the `flink-clients` were indeed wrong. Good catch!
    * It doesn't make much sense to set a main class for the uberjar. We don't use that property
anywhere. I removed it.
    * I've deactivated shading again for the quickstarts ..
    * It seems that the `asm` package changed the groupId around the `4.0` release. I'll add
both groupIds to the exclusions.
    
    I've updated the pull requests. Lets see what travis says about it: https://travis-ci.org/rmetzger/flink/builds/53795738


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message